Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwanted extra tab #743

Merged
merged 14 commits into from
Jan 15, 2024
Merged

Fix unwanted extra tab #743

merged 14 commits into from
Jan 15, 2024
+27 −26

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Oct 31, 2023 •
edited
Loading

Fixes #736

  • Application only adds an extra tab only when specifically asked
  • MainWindow adds an extra tab when required to ensure at least one tab

@jeremypw jeremypw mentioned this pull request Jan 10, 2024
Closed
@jeremypw jeremypw changed the title Fix unwanted extra tab Fix unwanted extra tab and recognize path abbreviations Jan 10, 2024
@jeremypw jeremypw marked this pull request as ready for review January 10, 2024 12:22
@jeremypw jeremypw requested a review from Marukesu January 10, 2024 12:22
@jeremypw
Copy link
Collaborator Author

Fixing CI ...

@jeremypw jeremypw marked this pull request as draft January 10, 2024 12:41
@jeremypw jeremypw marked this pull request as ready for review January 10, 2024 12:50
Marukesu
Marukesu requested changes Jan 13, 2024
View reviewed changes
src/Application.vala Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/MainWindow.vala Outdated Show resolved Hide resolved
src/tests/Application.vala Outdated Show resolved Hide resolved
Jeremy Wootten added 3 commits January 14, 2024 16:48
Simplify and clarify
97ce246 
 - Restore tabs for all first window
 - Simplify MainWindow constructor
 - DRY
Get wd from ApplicationCommandLine; fix test
9462bda
Revert sanitize
46a7a8f
@jeremypw jeremypw changed the title Fix unwanted extra tab and recognize path abbreviations Fix unwanted extra tab Jan 14, 2024
@jeremypw
Copy link
Collaborator Author

@Marukesu Thanks for the detailed review. I have tried to address your comments. I have reduced the scope of this PR to not include path abbreviations. This will be addressed in a separate PR.

If the behaviour is now as expected, please feel free to push a commit rearranging the code as you would like.

@jeremypw jeremypw requested a review from Marukesu January 14, 2024 17:48
@jeremypw
Copy link
Collaborator Author

I have now pushed a possible fix for the relative path issue. After this commit both io.elementary.terminal -w ../src and io.elementary.terminal --working-directory=../src behave as expected.

Marukesu
Marukesu approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeremypw jeremypw merged commit 501e689 into master Jan 15, 2024
4 checks passed
@jeremypw jeremypw deleted the fix-extra-tab-2 branch January 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marukesu Marukesu Marukesu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jeremypw @Marukesu